Skip to content

Comments

[v24.x backport] build: add support for Visual Studio 2026#61840

Open
MikeMcC399 wants to merge 109 commits intonodejs:v24.x-stagingfrom
MikeMcC399:backport-60727-to-v24.x
Open

[v24.x backport] build: add support for Visual Studio 2026#61840
MikeMcC399 wants to merge 109 commits intonodejs:v24.x-stagingfrom
MikeMcC399:backport-60727-to-v24.x

Conversation

@MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Feb 15, 2026 •
edited
Loading

Backporting 2 interrelated PRs:

commit a4b05c1
Author: Michaël Zasso targos@protonmail.com
Date: Wed Nov 19 17:01:37 2025 +0100

build: add support for Visual Studio 2026

Backport-PR-URL: https://github.com/nodejs/node/pull/61840
PR-URL: https://github.com/nodejs/node/pull/60727
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>

commit 25c5353
Author: Stefan Stojanovic stefan.stojanovic@janeasystems.com
Date: Wed Jan 28 15:52:43 2026 +0100

build,win: fix vs2022 compilation

Backport-PR-URL: https://github.com/nodejs/node/pull/61840
PR-URL: https://github.com/nodejs/node/pull/61530
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>

Situation

BUILDING > Supported toolchains for the v24.x branch shows:

Operating System Compiler Versions
Windows Visual Studio >= 2022 with the Windows 10 SDK on a 64-bit host

With only Visual Studio 2026 Build Tools Edition from https://visualstudio.microsoft.com/downloads/#build-tools-for-visual-studio-2026 installed with necessary prerequisites (no side-by-side Visual Studio 2022 installed), executing .\vcbuild in a PowerShell 7 terminal fails, although the "Supported toolchains" suggest that Visual Studio 2026 should be supported.

Looking for Visual Studio 2022
Failed to find a suitable Visual Studio installation with Clang compiler/LLVM toolset.

Change

Cherry-pick 934d907 from #60727

Preserve the [nocorepack] option in vcbuild.bat v24.x, which was removed for >=v25.x, to resolve a cherry-pick conflict.

Also cherry-pick 5a8864d from #61530 to fix a one line bug in #60727 which prevented selecting Visual Studio 2022 with .\vcbuild vs2022 in a side-by-side configuration where both Visual Studio 2022 and 2026 were installed.

Verification

In Windows 11 25H2 with Visual Studio 2022 & 2026 variously installed / not installed, ensure that all valid command combinations of .\vcbuild run:

Command Visual Studio 2022 installed Visual Studio 2026 installed Studio version selected
.\vcbuild YES NO vs2022
.\vcbuild vs2022 YES NO vs2022
.\vcbuild YES YES vs2026
.\vcbuild vs2022 YES YES vs2022
.\vcbuild vs2026 YES YES vs2026
.\vcbuild NO YES vs2026
.\vcbuild v2026 NO YES vs2026

mcollina and others added 30 commits February 10, 2026 15:11
@mcollina @aduh95
tls: route callback exceptions through error handlers
ebe01cc 
Wrap pskCallback and ALPNCallback invocations in try-catch blocks
to route exceptions through owner.destroy() instead of letting them
become uncaught exceptions. This prevents remote attackers from
crashing TLS servers or causing resource exhaustion.

Fixes: https://hackerone.com/reports/3473882
PR-URL: nodejs-private/node-private#782
PR-URL: nodejs-private/node-private#790
CVE-ID: CVE-2026-21637
@aduh95
test: ensure assertions are reached on more tests
b896ab4 
PR-URL: nodejs#60634
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@seriousme @aduh95
lib: add support for readable byte streams to .toWeb()
b764b84 
Add support for the creation of ReadableByteStream to Readable.toWeb()
and Duplex.toWeb()
This enables the use of .getReader({ mode: "byob" }) on
e.g. socket().toWeb()

Refs: nodejs#56004 (comment)
Refs: https://developer.mozilla.org/en-US/docs/Web/API/Streams_API/Using_readable_byte_streams
PR-URL: nodejs#58664
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Mattias Buelens <mattias@buelens.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@dependabot @aduh95
meta: bump actions/checkout from 5.0.0 to 5.0.1
f999960 
Bumps [actions/checkout](https://github.com/actions/checkout) from 5.0.0 to 5.0.1.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@08c6903...93cb6ef)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 5.0.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: nodejs#60767
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@hainenber @aduh95
repl: tab completion targets <class> instead of new <class>
80d6a48 
Signed-off-by: hainenber <dotronghai96@gmail.com>
PR-URL: nodejs#60319
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
@LiviaMedeiros @aduh95
lib: prefer call() over apply() if argument list is not array
1ad165a 
PR-URL: nodejs#60796
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Renegade334 @aduh95
events: repurpose events.listenerCount() to accept EventTargets
fa46e8f 
PR-URL: nodejs#60214
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@dependabot @aduh95
meta: bump actions/checkout from 5.0.1 to 6.0.0
fa8b635 
Bumps [actions/checkout](https://github.com/actions/checkout) from 5.0.1
to 6.0.0.

- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 6.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: nodejs#60925
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@hybrist @aduh95
module: allow subpath imports that start with #/
1cf109d 
It's a common ecosystem pattern to map a source root directory to
`@/` but it requires special tooling support. This turns `#/*` into
a more realistic alternative for that pattern.

PR-URL: nodejs#60864
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
@aduh95
test: skip tests not passing without NODE_OPTIONS support
a4edda0 
PR-URL: nodejs#60912
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@joyeecheung @aduh95
http: add http.setGlobalProxyFromEnv()
7424eaa 
This adds an API to dynamically enable built-in proxy support
for all of fetch() and http.request()/https.request(), so
that users do not have to be aware of them all and configure them
one by one.

PR-URL: nodejs#60953
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@ErickWendel @aduh95
util: add convertProcessSignalToExitCode utility
5f18ad3 
Add convertProcessSignalToExitCode() to convert signal names to POSIX
exit codes (128 + signal number). Exposed in public util API.

Refs: nodejs#60720
PR-URL: nodejs#60963
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@dario-piotrowicz @aduh95
repl: fix getters triggering side effects during completion
bdae330 
PR-URL: nodejs#61043
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Aviv Keller <me@aviv.sh>
@gurgunday @aduh95
process: preserve AsyncLocalStorage in queueMicrotask only when needed
a18cd1d 
PR-URL: nodejs#60913
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@Renegade334 @aduh95
stream: do not pass readable.compose() output via Readable.from()
239bf34 
PR-URL: nodejs#60907
Fixes: nodejs#55203
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@dependabot @aduh95
meta: bump actions/upload-artifact from 5.0.0 to 6.0.0
dffba04 
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 5.0.0 to 6.0.0.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@330a01c...b7c566a)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-version: 6.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: nodejs#61238
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@dependabot @aduh95
meta: bump actions/checkout from 6.0.0 to 6.0.1
7285f16 
Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.0 to 6.0.1.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@1af3b93...8e8c483)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 6.0.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: nodejs#61239
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@dependabot @aduh95
meta: bump actions/download-artifact from 6.0.0 to 7.0.0
a0c992c 
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 6.0.0 to 7.0.0.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@018cc2c...37930b1)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-version: 7.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: nodejs#61242
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@richardlau @aduh95
deps: V8: cherry-pick highway@dcc0ca1cd42
b6cb8cd 
Original commit message:

    Fix for GCC 15 compiler error on PPC8/PPC9/PPC10

Refs: google/highway@dcc0ca1
PR-URL: nodejs#61008
Fixes: nodejs#60992
Refs: google/highway#2443
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@aduh95
test: ensure assertions are reached on more tests
f1ab938 
PR-URL: nodejs#60728
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@aduh95
test: use RegExp.escape to improve test reliability
8b08f90 
PR-URL: nodejs#60803
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@aduh95
test: ensure assertions are reached on more tests
2a5c3ff 
PR-URL: nodejs#60760
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@aduh95
test: ensure assertions are reached on more tests
0ff565a 
PR-URL: nodejs#60763
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@aduh95
test: ensure assertions are reached on all tests
e547052 
PR-URL: nodejs#60845
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@aduh95
tools: enforce trailing commas in test/sequential
21b84fc 
PR-URL: nodejs#60892
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@aduh95
tools: enforce trailing commas in test/es-module
b48012f 
PR-URL: nodejs#60891
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@aduh95
test: enforce better never-settling-promise detection
3dfb47f 
Tests should be explicit regarding whether a promise is expected to
settle, and the test should fail when the behavior does not meet
expectations.

PR-URL: nodejs#60976
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
@aduh95
test: forbid use of named imports for fixtures
3e4255d 
PR-URL: nodejs#61228
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
@Hardanish-Singh @aduh95
doc: clean up writing-and-running-benchmarks.md
3b27cc8 
PR-URL: nodejs#61345
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@JakobJingleheimer @vespa7 @aduh95
test_runner: support expecting a test-case to fail
bae6111 
Co-Authored-By: Alejandro Espa <98526766+vespa7@users.noreply.github.com>
PR-URL: nodejs#60669
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
@anonrig @aduh95
build,deps: replace cjs-module-lexer with merve
5cfc065 
PR-URL: nodejs#61456
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. windows Issues and PRs related to the Windows platform. labels Feb 15, 2026
@MikeMcC399 MikeMcC399 marked this pull request as ready for review February 15, 2026 18:06
This was referenced Feb 15, 2026
Merged
Open
Open
Open
@Renegade334
Copy link
Member

Renegade334 commented Feb 17, 2026

For releasers, can you prepend Backport-PR-URL: https://github.com/nodejs/node/pull/61840 to your commit trailers?

targos and others added 2 commits February 18, 2026 10:33
@targos @MikeMcC399
build: add support for Visual Studio 2026
a4b05c1 
Backport-PR-URL: nodejs#61840
PR-URL: nodejs#60727
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
@StefanStojanovic @MikeMcC399
build,win: fix vs2022 compilation
25c5353 
Backport-PR-URL: nodejs#61840
PR-URL: nodejs#61530
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@MikeMcC399 MikeMcC399 force-pushed the backport-60727-to-v24.x branch from 1f34ed6 to 25c5353 Compare February 18, 2026 09:35
@MikeMcC399
Copy link
Contributor Author

MikeMcC399 commented Feb 18, 2026

@Renegade334

For releasers, can you prepend Backport-PR-URL: #61840 to your commit trailers?

Thanks for your guidance! I did read in https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md#manual-process that it says:

The Backport-PR-URL metadata does need to be added to the commit, but this will be done later.

So the instructions aren't really very specific about whose action this is and what is supposed to be done.

I have added the Backport-PR-URL metadata now and force pushed. Hopefully I got this right!

@Renegade334
Copy link
Member

Renegade334 commented Feb 18, 2026

Thanks. I believe that advice only applies to git node backport which adds the backport metadata during the landing session.

@Renegade334 Renegade334 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 18, 2026
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Feb 18, 2026
@github-actions

This comment has been minimized.

Sign in to view
@MikeMcC399

This comment was marked as resolved.

Sign in to view
@Renegade334 Renegade334 added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Feb 18, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 18, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71368/

@aduh95 aduh95 requested a review from a team as a code owner February 22, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Renegade334 Renegade334 Renegade334 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.